Summary: | Fix OwnPtr strict issues in windows build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | Platform | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 59428 | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2011-05-01 10:10:12 PDT
Created attachment 91827 [details]
Patch
Attachment 91827 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/win/CursorWin.cpp:85: Use 0 instead of NULL. [readability/null] [5]
Source/WebKit/win/WebView.cpp:1053: Missing space after , [whitespace/comma] [3]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks!! Comment on attachment 91827 [details] Patch Clearing flags on attachment: 91827 Committed r85420: <http://trac.webkit.org/changeset/85420> All reviewed patches have been landed. Closing bug. |