Bug 59861

Summary:

Enable strict OwnPtr for GTK

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, gustavo.noronha, gustavo, mrobinson, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

59428

Attachments:

Description	Flags
Patch	none
Updated patch	none
Patch	none

Adam Barth

Reported 2011-04-29 20:53:01 PDT

Enable strict OwnPtr for GTK

Attachments
Patch (1.02 KB, patch) 2011-04-29 21:10 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Updated patch (8.15 KB, patch) 2011-04-30 14:22 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (16.17 KB, patch) 2011-04-30 18:46 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-04-29 21:10:58 PDT

Created attachment 91795 [details] Patch

Collabora GTK+ EWS bot

Comment 2 2011-04-30 00:20:43 PDT

Attachment 91795 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8530025

Martin Robinson

Comment 3 2011-04-30 14:22:38 PDT

Created attachment 91806 [details] Updated patch

Adam Barth

Comment 4 2011-04-30 14:27:14 PDT

Comment on attachment 91806 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review > Source/WebCore/page/Geolocation.cpp:220 > - , m_service(GeolocationService::create(this)) > + , m_service(adoptPtr(GeolocationService::create(this))) Should GeolocationService::create return a PassOwnPtr instead? > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56 > + OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context()))); We tend to prefer the assignment form of the constructor for OwnPtr.

Martin Robinson

Comment 5 2011-04-30 18:46:01 PDT

Created attachment 91810 [details] Patch

Martin Robinson

Comment 6 2011-04-30 18:50:36 PDT

(In reply to comment #4) > (From update of attachment 91806 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review Thanks for the quick review. > > Source/WebCore/page/Geolocation.cpp:220 > > - , m_service(GeolocationService::create(this)) > > + , m_service(adoptPtr(GeolocationService::create(this))) > > Should GeolocationService::create return a PassOwnPtr instead? Indeed it should. I've made this change and pushed the fixes down to all the GeolocationService factory methods. > > > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56 > > + OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context()))); > We tend to prefer the assignment form of the constructor for OwnPtr. Fixed! I think I'll write an email to propose this for the style guide.

WebKit Commit Bot

Comment 7 2011-04-30 21:16:44 PDT

Comment on attachment 91810 [details] Patch Clearing flags on attachment: 91810 Committed r85405: <http://trac.webkit.org/changeset/85405>

WebKit Commit Bot

Comment 8 2011-04-30 21:16:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.