Bug 59856 – Plug-in failed to initialize message should be called when Java fails to initialize

• Component: New Bugs
• Status: RESOLVED FIXED

[Steve Falkenburg]

Plug-in failed to initialize message should be called when Java fails to initialize

[Steve Falkenburg]

Created attachment 91784 [details]
Patch

[Maciej Stachowiak]

Comment on attachment 91784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91784&action=review

r=me

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1257
> +    const String mimeType = "application/x-java-applet";

I suggest naming this javaMimeType or appletMimeType or something like that.

[Sam Weinig]

I don't understand this patch.  This is not checking initialization, but rather whether a java plugin exists or not.

[Steve Falkenburg]

Inside WebPage::createPlugin for the failure case, GetPluginPath succeeds, returning the proper path to the Java plug-in.

The failure occurs when NetscapePluginModule::getOrCreate calls pluginModule->load() to initialize the plug-in. When this fails, getOrCreate returns 0, and then createPlugin returns 0.

The Java applet path doesn't appear to use PluginView, so the call you added to DidFailToInitializePlugin in PluginView::initializePlugin doesn't get called in this case.

I'd be open to fixing this another way - let me know.

[Steve Falkenburg]

Committed r85493: <http://trac.webkit.org/changeset/85493>