Summary: | IndexedDB does not update r/w index cursors that are mutated during iteration | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dgrogan, fishd, hans, jsbell, pilgrim, tony, webkit.review.bot | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-04-29 13:25:32 PDT
Created attachment 91723 [details]
Test case
Not a patch, just a test case. Removed spurious review flag. Just curious, do we correctly handle this case if the cursor is iterating over an objectstore rather than an index? (In reply to comment #4) > Yes, see bug 59933. Hmm, that's interesting. Thanks for finding this. Created attachment 118266 [details]
updated test case
No repro for me. This may have been fixed with the move to LevelDB.
The attached test case was a bit crufty; I dusted it off (attached) and it works fine.
On further thought, we should probably pull in this test, but perhaps keep it closer to the original moz test than my edit. Created attachment 124384 [details]
Patch
Comment on attachment 124384 [details]
Patch
Dusted off the original patch a bit. Still passes as expected.
Comment on attachment 124384 [details]
Patch
LGTM
Comment on attachment 124384 [details] Patch Clearing flags on attachment: 124384 Committed r106165: <http://trac.webkit.org/changeset/106165> All reviewed patches have been landed. Closing bug. |