Bug 59811

Summary:

Extract a function to obtain VisiblePosition from RenderText::positionForPoint

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, darin, eric, hyatt, jamesr, mitz, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

59435

Attachments:

Description	Flags
cleanup	none

Description Ryosuke Niwa 2011-04-29 11:09:57 PDT

The part of RenderText::positionForPoint that returns visible positions when various conditions are met can be split into a separate function.

Comment 1 Ryosuke Niwa 2011-04-29 12:11:14 PDT

Created attachment 91716 [details]
cleanup

Comment 2 Eric Seidel (no email) 2011-04-29 17:31:02 PDT

Comment on attachment 91716 [details]
cleanup

LGTM.

Comment 3 Ryosuke Niwa 2011-04-29 17:32:34 PDT

Thanks for the review, Eric.

Comment 4 WebKit Commit Bot 2011-04-29 18:12:28 PDT

The commit-queue encountered the following flaky tests while processing attachment 91716 [details]:

http/tests/workers/shared-worker-importScripts.html bug 58634 (author: atwilson@chromium.org)
The commit-queue is continuing to process your patch.

Comment 5 WebKit Commit Bot 2011-04-29 18:13:39 PDT

Comment on attachment 91716 [details]
cleanup

Clearing flags on attachment: 91716

Committed r85377: <http://trac.webkit.org/changeset/85377>

Comment 6 WebKit Commit Bot 2011-04-29 18:13:45 PDT

All reviewed patches have been landed.  Closing bug.