Bug 59798

Summary: Implement FULLSCREEN_API on Windows, Part 4: Enable it
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, buildbot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59785, 59845    
Bug Blocks:    
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Jer Noble
Reported 2011-04-29 09:09:56 PDT
Implement FULLSCREEN_API on Windows, Part 4: Enable it
Attachments
Patch (3.51 KB, patch)
2011-04-29 10:15 PDT, Jer Noble 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-04-29 10:15:40 PDT
Created attachment 91694 [details] Patch
Build Bot
Comment 2 2011-04-29 14:23:25 PDT
Attachment 91694 [details] did not build on win: Build output: http://queues.webkit.org/results/8525190
Adam Roben (:aroben)
Comment 3 2011-04-29 18:48:06 PDT
(In reply to comment #2) > Attachment 91694 [details] did not build on win: > Build output: http://queues.webkit.org/results/8525190 Uh-oh!
Jer Noble
Comment 4 2011-04-29 18:58:13 PDT
(In reply to comment #3) > (In reply to comment #2) > > Attachment 91694 [details] [details] did not build on win: > > Build output: http://queues.webkit.org/results/8525190 > > Uh-oh! We may have to kick the builders when this patch goes in, if the scripts don't regenerate the UserAgentStyleSheetsData.cpp file.
Jer Noble
Comment 5 2011-04-29 19:01:21 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Attachment 91694 [details] [details] [details] did not build on win: > > > Build output: http://queues.webkit.org/results/8525190 > > > > Uh-oh! > > We may have to kick the builders when this patch goes in, if the scripts don't regenerate the UserAgentStyleSheetsData.cpp file. I'll make a inconsequential change to the fullscreen.css file; that should "encourage" the DerivedSources.make file that it needs to rebuild UserAgentStyleSheetsData.cpp.
Eric Seidel (no email)
Comment 6 2011-05-01 09:51:14 PDT
Comment on attachment 91694 [details] Patch Ok. I assume this is dependent on earlier patches.
Jer Noble
Comment 7 2011-05-01 13:28:03 PDT
(In reply to comment #6) > (From update of attachment 91694 [details]) > Ok. I assume this is dependent on earlier patches. It sure is. :) Thanks!
Jer Noble
Comment 8 2011-05-03 23:25:52 PDT
Committed r85719: <http://trac.webkit.org/changeset/85719>
Note You need to log in before you can comment on or make changes to this bug.