Bug 59783
Summary: | sheriffbot gets angry when the build master is restarted | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | abarth, eric, wsiegrist |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All |
Adam Roben (:aroben)
When the build master is restarted, sheriffbot starts thinking that builds/tests have failed. It needs to chill out!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
This has happened multiple times today, including just now.
Adam Barth
:(
Eric Seidel (no email)
sheriff-bot knows to ignore lost builders. but I guess he needs to be taught what restarts look like.
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py#L313
What do they look like?
This is the file which decides what are failures to complain about, btw:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/failuremap.py
which is used by:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py
the actual communication with irc/bugzilla is done here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py
Adam Roben (:aroben)
(In reply to comment #3)
> What do they look like?
Every build gets interrupted at once. They all go "purple" due to an exception being thrown.
Adam Roben (:aroben)
I guess maybe they don't always go purple. Anyway, here's a few such interrupted builds:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/34171
http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/13238
http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/21106
Eric Seidel (no email)
"lost" in that text should be enough to make buildbot.py treat them as green.
If they were failing before, it's possible it would then report "new" failures when they come back, and go from "green" to red.
Eric Seidel (no email)
SB no longer watches builders, so this is probably obsolete now.
Eric Seidel (no email)
*** Bug 37099 has been marked as a duplicate of this bug. ***