Summary: | [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Kyzivat <kamaji> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jturcotte, kling, laszlo.gombos, ossy, yael | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Keith Kyzivat
2011-04-28 19:47:14 PDT
Created attachment 91622 [details]
Patch
Comment on attachment 91622 [details]
Patch
r- now, because DEFINES is emtpy here.
Please add an "include(../Source/WebCore/features.pri)" line
after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work.
(In reply to comment #2) > (From update of attachment 91622 [details]) > r- now, because DEFINES is emtpy here. > > Please add an "include(../Source/WebCore/features.pri)" line > after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work. Oh duh! This worked for me during testing because I had ENABLE_NETSCAPE_PLUGIN_API defined on the command line. Created attachment 91721 [details]
Patch
Comment on attachment 91721 [details]
Patch
Thanks, r=me
Comment on attachment 91721 [details] Patch Clearing flags on attachment: 91721 Committed r85370: <http://trac.webkit.org/changeset/85370> All reviewed patches have been landed. Closing bug. |