Bug 59763

Summary:

DFG JIT - Unify FPRReg & FPRegisterID

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
The patch	none
Tweaked Patch!	none
Ooops! reverted Node changes!	none
Double ooops! - revert platform change!	oliver: review+

Gavin Barraclough

Reported 2011-04-28 17:06:25 PDT

(Following on from GPRReg/RegisterID unification).

Attachments
The patch (48.85 KB, patch) 2011-04-28 17:07 PDT, Gavin Barraclough	no flags	Details Formatted Diff Diff
Tweaked Patch! (54.02 KB, patch) 2011-04-28 17:15 PDT, Gavin Barraclough	no flags	Details Formatted Diff Diff
Ooops! reverted Node changes! (53.16 KB, patch) 2011-04-28 17:16 PDT, Gavin Barraclough	no flags	Details Formatted Diff Diff
Double ooops! - revert platform change! (52.61 KB, patch) 2011-04-28 17:18 PDT, Gavin Barraclough	oliver: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Gavin Barraclough

Comment 1 2011-04-28 17:07:54 PDT

Created attachment 91595 [details] The patch

WebKit Review Bot

Comment 2 2011-04-28 17:09:30 PDT

Attachment 91595 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGFPRInfo.h:60: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/dfg/DFGFPRInfo.h:91: fpr_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 3 2011-04-28 17:15:45 PDT

Created attachment 91599 [details] Tweaked Patch!

Gavin Barraclough

Comment 4 2011-04-28 17:16:58 PDT

Created attachment 91600 [details] Ooops! reverted Node changes!

WebKit Review Bot

Comment 5 2011-04-28 17:17:08 PDT

Attachment 91599 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGFPRInfo.h:60: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/dfg/DFGFPRInfo.h:91: fpr_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 6 2011-04-28 17:18:15 PDT

Created attachment 91601 [details] Double ooops! - revert platform change!

WebKit Review Bot

Comment 7 2011-04-28 17:19:46 PDT

Attachment 91600 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGFPRInfo.h:60: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/dfg/DFGFPRInfo.h:91: fpr_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 8 2011-04-28 17:20:32 PDT

Attachment 91601 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGFPRInfo.h:60: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/dfg/DFGFPRInfo.h:91: fpr_iterator is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gavin Barraclough

Comment 9 2011-04-28 18:50:35 PDT

ixed in r85271

Note You need to log in before you can comment on or make changes to this bug.