Bug 59760

Summary: Right-clicking on a Flash movie in an iframe shows the browser context menu
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2011-04-28 16:32:33 PDT
Right-clicking on a Flash movie in an iframe shows the browser context menu
Attachments
Patch (2.60 KB, patch)
2011-04-28 16:37 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-04-28 16:37:23 PDT
Created attachment 91587 [details] Patch
Darin Adler
Comment 2 2011-04-28 16:40:02 PDT
Comment on attachment 91587 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91587&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956 > + return handleContextMenuEvent(platformMouseEvent, page); Is it really OK to ignore the result of “handled” entirely here? Not || it in? Is it correct to return false if the mouse press event was handled, but not the context menu event?
Anders Carlsson
Comment 3 2011-04-28 16:41:39 PDT
Comment on attachment 91587 [details] Patch I think so; the semantics are still the same as they were before my change.
Anders Carlsson
Comment 4 2011-04-28 16:44:32 PDT
Committed r85259: <http://trac.webkit.org/changeset/85259>
Note You need to log in before you can comment on or make changes to this bug.