Bug 59760

Summary:

Right-clicking on a Flash movie in an iframe shows the browser context menu

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2011-04-28 16:32:33 PDT

Right-clicking on a Flash movie in an iframe shows the browser context menu

Comment 1 Anders Carlsson 2011-04-28 16:37:23 PDT

Created attachment 91587 [details]
Patch

Comment 2 Darin Adler 2011-04-28 16:40:02 PDT

Comment on attachment 91587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91587&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956
> +                return handleContextMenuEvent(platformMouseEvent, page);

Is it really OK to ignore the result of “handled” entirely here? Not || it in? Is it correct to return false if the mouse press event was handled, but not the context menu event?

Comment 3 Anders Carlsson 2011-04-28 16:41:39 PDT

Comment on attachment 91587 [details]
Patch

I think so; the semantics are still the same as they were before my change.

Comment 4 Anders Carlsson 2011-04-28 16:44:32 PDT

Committed r85259: <http://trac.webkit.org/changeset/85259>