Bug 59756

Summary: Chromium Mac: Enable overlay scrollbars
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, jamesr, mihaip, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 61401    
Bug Blocks: 59728    
Attachments:
Description Flags
Patch
none
Fixed some bugs
none
Updated change log.
none
Fixed style errors
none
Patch
none
Patch
none
Patch none

Sailesh Agrawal
Reported 2011-04-28 16:11:32 PDT
This bug is to track the work to enable overlay scrollbars.
Attachments
Patch (16.46 KB, patch)
2011-04-28 16:16 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Fixed some bugs (19.19 KB, patch)
2011-04-29 14:02 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Updated change log. (19.54 KB, patch)
2011-04-29 14:14 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Fixed style errors (19.54 KB, patch)
2011-04-29 14:18 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (16.33 KB, patch)
2011-05-24 14:46 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (30.83 KB, patch)
2011-06-08 12:10 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (30.83 KB, patch)
2011-06-08 14:46 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1 2011-04-28 16:16:38 PDT
Created attachment 91581 [details] Patch
WebKit Review Bot
Comment 2 2011-04-28 16:52:53 PDT
Attachment 91581 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sailesh Agrawal
Comment 3 2011-04-29 14:02:18 PDT
Created attachment 91729 [details] Fixed some bugs
WebKit Review Bot
Comment 4 2011-04-29 14:04:38 PDT
Attachment 91729 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sailesh Agrawal
Comment 5 2011-04-29 14:14:33 PDT
Created attachment 91736 [details] Updated change log.
Sailesh Agrawal
Comment 6 2011-04-29 14:18:28 PDT
Created attachment 91739 [details] Fixed style errors
Sam Weinig
Comment 7 2011-05-01 13:30:37 PDT
Comment on attachment 91739 [details] Fixed style errors This again contains copied code. Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.
Sailesh Agrawal
Comment 8 2011-05-24 14:46:53 PDT
Created attachment 94692 [details] Patch
Sailesh Agrawal
Comment 9 2011-05-24 14:49:09 PDT
(In reply to comment #7) > (From update of attachment 91739 [details]) > This again contains copied code. Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding. I've updated the ChangeLog to describe what's added and changed. I talked to Beth Dakin about the code duplication issue. We agreed that it would be ok to live with the code duplication until smooth scrolling is enabled on the Mac (hopefully very soon). I've filed bug 61144 to track this issue.
Sailesh Agrawal
Comment 10 2011-06-08 12:10:37 PDT
Created attachment 96452 [details] Patch
Sailesh Agrawal
Comment 11 2011-06-08 14:24:20 PDT
Try bot passed: http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/31160
Mihai Parparita
Comment 12 2011-06-08 14:40:32 PDT
Comment on attachment 96452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review > Source/JavaScriptCore/ChangeLog:8 > + Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X. One too many spaces after "Enable"
Sailesh Agrawal
Comment 13 2011-06-08 14:46:20 PDT
Created attachment 96485 [details] Patch
Sailesh Agrawal
Comment 14 2011-06-08 14:46:46 PDT
Comment on attachment 96452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X. > > One too many spaces after "Enable" Fixed.
WebKit Review Bot
Comment 15 2011-06-08 15:24:49 PDT
Comment on attachment 96485 [details] Patch Clearing flags on attachment: 96485 Committed r88396: <http://trac.webkit.org/changeset/88396>
WebKit Review Bot
Comment 16 2011-06-08 15:24:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.