Summary: | Chromium Mac: Enable overlay scrollbars | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sailesh Agrawal <sail> | ||||||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | bdakin, jamesr, mihaip, thakis, webkit.review.bot | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | PC | ||||||||||||||||||
OS: | OS X 10.5 | ||||||||||||||||||
Bug Depends on: | 61401 | ||||||||||||||||||
Bug Blocks: | 59728 | ||||||||||||||||||
Attachments: |
|
Description
Sailesh Agrawal
2011-04-28 16:11:32 PDT
Created attachment 91581 [details]
Patch
Attachment 91581 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 91729 [details]
Fixed some bugs
Attachment 91729 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 91736 [details]
Updated change log.
Created attachment 91739 [details]
Fixed style errors
Comment on attachment 91739 [details]
Fixed style errors
This again contains copied code. Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding.
Created attachment 94692 [details]
Patch
(In reply to comment #7) > (From update of attachment 91739 [details]) > This again contains copied code. Why does chromium mac need its own ScrollBarTheme code? Alos, your changelog entries do not have any information about the functions you are adding. I've updated the ChangeLog to describe what's added and changed. I talked to Beth Dakin about the code duplication issue. We agreed that it would be ok to live with the code duplication until smooth scrolling is enabled on the Mac (hopefully very soon). I've filed bug 61144 to track this issue. Created attachment 96452 [details]
Patch
Comment on attachment 96452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review > Source/JavaScriptCore/ChangeLog:8 > + Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X. One too many spaces after "Enable" Created attachment 96485 [details]
Patch
Comment on attachment 96452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96452&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X. > > One too many spaces after "Enable" Fixed. Comment on attachment 96485 [details] Patch Clearing flags on attachment: 96485 Committed r88396: <http://trac.webkit.org/changeset/88396> All reviewed patches have been landed. Closing bug. |