Summary: | fast/harness/results.html failing in some configurations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dpranke, eric, kbr, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 59711 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Kenneth Russell
2011-04-28 15:36:42 PDT
Created attachment 91575 [details]
Patch
Comment on attachment 91575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review > LayoutTests/fast/harness/resources/results-test.js:318 > + // Use a regexp to match windows and unix-style paths. Never heard of windows and unix, maybe you mean Windows and Unix? ;-) > LayoutTests/fast/harness/resources/results-test.js:319 > + var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html'); Does this need a ^ and a $, or does the exec function only match the entire URL? (In reply to comment #2) > (From update of attachment 91575 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review > > > LayoutTests/fast/harness/resources/results-test.js:318 > > + // Use a regexp to match windows and unix-style paths. > > Never heard of windows and unix, maybe you mean Windows and Unix? ;-) lol. Will fix. > > LayoutTests/fast/harness/resources/results-test.js:319 > > + var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html'); > > Does this need a ^ and a $, or does the exec function only match the entire URL? Oh good point. It does need them. Committed r85260: <http://trac.webkit.org/changeset/85260> |