| Summary: | -[WebPDFView menuForEvent:] leaks NSMenuItem objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | |||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, sullivan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | 3711 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Attachment 91537 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #0) > Regressed in r9566. <http://trac.webkit.org/changeset/9566> (In reply to comment #2) > (In reply to comment #0) > > Regressed in r9566. > <http://trac.webkit.org/changeset/9566> Bug 3711! Comment on attachment 91537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91537&action=review > Source/WebKit/mac/WebView/WebPDFView.mm:395 > + [menu addItem:[[menuItem copy] autorelease]]; It’s normally better to use release than autorelease. We could do that by adding a local variable. Committed r85230: <http://trac.webkit.org/changeset/85230> (In reply to comment #4) > (From update of attachment 91537 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91537&action=review > > > Source/WebKit/mac/WebView/WebPDFView.mm:395 > > + [menu addItem:[[menuItem copy] autorelease]]; > > It’s normally better to use release than autorelease. We could do that by adding a local variable. Committed r85237: <http://trac.webkit.org/changeset/85237> |
Created attachment 91537 [details] Patch Reviewed by NOBODY (OOPS!). * WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Call -autorelease after copying each NSMenuItem. Regressed in r9566. --- 2 files changed, 11 insertions(+), 1 deletions(-)