Bug 59696

Summary: Chromium DevTools: Fix network panel timing/size/headers tests.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review-
Patch with fixes none

Vsevolod Vlasov
Reported 2011-04-28 06:41:40 PDT
Fix network panel timing/size/headers tests. Timing/size tests are flaky now, should be more stable. Test expectations for headers text should be updated.
Attachments
Patch (5.09 KB, patch)
2011-04-28 06:46 PDT, Vsevolod Vlasov 		pfeldman: review-
DetailsFormatted DiffDiff
Patch with fixes (4.69 KB, patch)
2011-04-29 02:54 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-04-28 06:46:57 PDT
Created attachment 91482 [details] Patch
Pavel Feldman
Comment 2 2011-04-28 10:47:28 PDT
Comment on attachment 91482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91482&action=review > Source/WebKit/chromium/src/js/Tests.js:533 > + test.assertTrue(resource.transferSize === 219 || resource.transferSize === 221, 219 or 221? :) why? > Source/WebKit/chromium/src/js/Tests.js:534 > + "Incorrect total encoded data length: should be 219 (or 221), but was resource.transferSize=" + resource.transferSize + "."); weird indent. > Source/WebKit/chromium/src/js/Tests.js:559 > + "Incorrect total encoded data length: should be 219 (or 221), but was resource.transferSize=" + resource.transferSize + "."); ditto
Vsevolod Vlasov
Comment 3 2011-04-29 02:54:54 PDT
Created attachment 91657 [details] Patch with fixes
WebKit Commit Bot
Comment 4 2011-04-29 03:23:17 PDT
Comment on attachment 91657 [details] Patch with fixes Clearing flags on attachment: 91657 Committed r85314: <http://trac.webkit.org/changeset/85314>
WebKit Commit Bot
Comment 5 2011-04-29 03:23:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.