Bug 59679

Summary: [GTK] Create the page client in the view widget
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Updated patch none

Description Carlos Garcia Campos 2011-04-28 01:59:21 PDT 
Instead of the opposite, it looks more natural to me and simplifies WKView code.
Comment 1 Carlos Garcia Campos 2011-04-28 02:07:49 PDT 
Created attachment 91451 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-04-28 03:12:22 PDT 
Created attachment 91455 [details]
Updated patch

I forgot to use new for the private struct, instead of GObject mechanism, so that page client and web page objecs are correctly released.
Comment 3 Martin Robinson 2011-04-28 08:47:17 PDT 
Comment on attachment 91455 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91455&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:379
> +    priv->page->initializeWebPage();

Where is this method defined?

> Source/WebKit2/UIProcess/gtk/WebView.h:50
> +    WebPageProxy* page() const;

Please call this one pageProxy, just to be clear.
Comment 4 Martin Robinson 2011-04-28 08:52:36 PDT 
Comment on attachment 91455 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91455&action=review

>> Source/WebKit2/UIProcess/gtk/WebView.h:50
>> +    WebPageProxy* page() const;
> 
> Please call this one pageProxy, just to be clear.

Carlos reminded me that we are about to remove this.
Comment 5 Carlos Garcia Campos 2011-04-28 09:39:41 PDT 
Committed r85196: <http://trac.webkit.org/changeset/85196>