Bug 59674

Summary:

Add way to install testapi in production builds

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	ddkilzer: review+

Description Sam Weinig 2011-04-27 23:12:22 PDT

Add way to install testapi in production builds

Comment 1 Sam Weinig 2011-04-27 23:13:37 PDT

Created attachment 91432 [details]
Patch

Comment 2 Mark Rowe (bdash) 2011-04-27 23:19:21 PDT

Comment on attachment 91432 [details]
Patch

Can you recreate this without the svn cp of JavaScriptCore.xcconfig to TestAPI.xcconfig?  The change itself looks good, but that gives bogus history.

Comment 3 Sam Weinig 2011-04-28 08:30:17 PDT

Created attachment 91496 [details]
Patch

Comment 4 David Kilzer (:ddkilzer) 2011-04-28 09:05:01 PDT

Comment on attachment 91496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91496&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +        Remove in project build settings and add missing configuration files.

Nit: "in project" should be hyphenated as "in-project" since it's used as an adjective.

You should also note that you're adding CompilerVersion.xcconfig here since that is just an additional clean-up step.  (It should also be done for the other 4 projects that added it.)

Comment 5 Sam Weinig 2011-04-28 09:07:20 PDT

Committed r85189: <http://trac.webkit.org/changeset/85189>