Bug 59668

Summary: [chromium] Compute compositor fps value and history using the frameBegin timestamp
Product: WebKit Reporter: Nat Duca <nduca>
Component: New BugsAssignee: Nat Duca <nduca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, fishd, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
chromiuuuuuuuuuuuuuuuuum ftw none

Nat Duca
Reported 2011-04-27 20:19:12 PDT
[chromium] Compute compositor fps value and history using the frameBegin timestamp
Attachments
Patch (7.82 KB, patch)
2011-04-27 20:54 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch (7.15 KB, patch)
2011-04-28 10:00 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch (7.18 KB, patch)
2011-04-28 12:50 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
chromiuuuuuuuuuuuuuuuuum ftw (7.17 KB, patch)
2011-04-28 14:10 PDT, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2011-04-27 20:54:26 PDT
Created attachment 91420 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-28 02:02:47 PDT
Comment on attachment 91420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91420&action=review > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:58 > +using namespace WTF; Generally wtf headers do this for you... > Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:16 > + * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AYN Nope.
Nat Duca
Comment 3 2011-04-28 10:00:51 PDT
Created attachment 91508 [details] Patch
Darin Fisher (:fishd, Google)
Comment 4 2011-04-28 12:47:45 PDT
Comment on attachment 91508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91508&action=review R=me, but please fix nits before committing. > Source/WebCore/ChangeLog:9 > + beginning of the frame rather than the time we call swapBuffers. When scheudling is oops: scheudling > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:196 > + // This value is currently inaccessible because it is up in RenderWidget. I think you mean Chromium's RenderWidget (render_widget.cc), but this could be confused with WebCore::RenderWidget.
Nat Duca
Comment 5 2011-04-28 12:50:54 PDT
Created attachment 91541 [details] Patch
Darin Fisher (:fishd, Google)
Comment 6 2011-04-28 13:18:38 PDT
Comment on attachment 91541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91541&action=review > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:196 > + // This value is currently inaccessible because it is up in Chromiuum's Chromiuum -> Chromium
Nat Duca
Comment 7 2011-04-28 14:10:49 PDT
Created attachment 91551 [details] chromiuuuuuuuuuuuuuuuuum ftw
WebKit Commit Bot
Comment 8 2011-04-28 16:50:06 PDT
Comment on attachment 91551 [details] chromiuuuuuuuuuuuuuuuuum ftw Clearing flags on attachment: 91551 Committed r85261: <http://trac.webkit.org/changeset/85261>
WebKit Commit Bot
Comment 9 2011-04-28 16:50:11 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2011-04-28 17:01:42 PDT
http://trac.webkit.org/changeset/85261 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.