| Summary: | [Qt]Enable strict OwnPtr | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, levin, ossy, webkit-ews | ||||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 59675 | ||||||||||
| Bug Blocks: | 59428 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Barth
2011-04-27 18:28:12 PDT
Created attachment 91400 [details]
Patch
This is speculative. Comment on attachment 91400 [details]
Patch
Just trying to improve my r+ stats.
Attachment 91400 [details] did not build on qt: Build output: http://queues.webkit.org/results/8514408 Created attachment 91406 [details]
Patch
Hum... The bot only reports one error per run. This could take a while... Attachment 91406 [details] did not build on qt: Build output: http://queues.webkit.org/results/8519156 Created attachment 91691 [details]
Patch
Comment on attachment 91691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91691&action=review > Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:52 > { Y no m_painter(adoptPtr(new QPainter)) ? Landed in http://trac.webkit.org/changeset/85343 And a buildfix landed in http://trac.webkit.org/changeset/85349 And one more buildfix: http://trac.webkit.org/changeset/85357 |