Bug 59667

Summary: [Qt]Enable strict OwnPtr
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin, ossy, webkit-ews
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Bug Depends on: 59675    
Bug Blocks: 59428    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2011-04-27 18:28:12 PDT
Enable strict OwnPtr for Qt
Attachments
Patch (958 bytes, patch)
2011-04-27 18:28 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2011-04-27 18:57 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.56 KB, patch)
2011-04-29 09:47 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-27 18:28:25 PDT
Created attachment 91400 [details] Patch
Adam Barth
Comment 2 2011-04-27 18:28:55 PDT
This is speculative.
David Levin
Comment 3 2011-04-27 18:29:03 PDT
Comment on attachment 91400 [details] Patch Just trying to improve my r+ stats.
Early Warning System Bot
Comment 4 2011-04-27 18:51:03 PDT
Attachment 91400 [details] did not build on qt: Build output: http://queues.webkit.org/results/8514408
Adam Barth
Comment 5 2011-04-27 18:57:41 PDT
Created attachment 91406 [details] Patch
Adam Barth
Comment 6 2011-04-27 18:57:55 PDT
Hum... The bot only reports one error per run. This could take a while...
Early Warning System Bot
Comment 7 2011-04-27 19:19:36 PDT
Attachment 91406 [details] did not build on qt: Build output: http://queues.webkit.org/results/8519156
Csaba Osztrogonác
Comment 8 2011-04-29 09:47:45 PDT
Created attachment 91691 [details] Patch
Tor Arne Vestbø
Comment 9 2011-04-29 10:18:01 PDT
Comment on attachment 91691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91691&action=review > Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:52 > { Y no m_painter(adoptPtr(new QPainter)) ?
Csaba Osztrogonác
Comment 10 2011-04-29 11:54:25 PDT
Landed in http://trac.webkit.org/changeset/85343
Csaba Osztrogonác
Comment 11 2011-04-29 12:31:03 PDT
And a buildfix landed in http://trac.webkit.org/changeset/85349
Csaba Osztrogonác
Comment 12 2011-04-29 14:01:53 PDT
And one more buildfix: http://trac.webkit.org/changeset/85357
Note You need to log in before you can comment on or make changes to this bug.