Bug 59664

Summary:

Fix OwnPtr strict issues in chromium linux build

Product:

WebKit

Reporter:

James Robinson <jamesr>

Component:

New Bugs

Assignee:

James Robinson <jamesr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, kbr

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

59666

Attachments:

Description	Flags
Patch	abarth: review+

Description James Robinson 2011-04-27 18:22:13 PDT

Fix OwnPtr strict issues in chromium linux build

Comment 1 James Robinson 2011-04-27 18:22:42 PDT

Created attachment 91395 [details]
Patch

Comment 2 Adam Barth 2011-04-27 18:27:37 PDT

Comment on attachment 91395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91395&action=review

> Source/WebKit/chromium/src/WebImageDecoder.cpp:115
> -    OwnPtr<NativeImageSkia>image(frameBuffer->asNewNativeImage());
> +    OwnPtr<NativeImageSkia> image(adoptPtr(frameBuffer->asNewNativeImage()));

We usually prefer the = form of the constructor.

Comment 3 James Robinson 2011-04-27 18:42:31 PDT

Committed r85135: <http://trac.webkit.org/changeset/85135>