Bug 59645

Summary: Add ability to remove keys from weakmap API
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2011-04-27 15:58:53 PDT
Add ability to remove keys from weakmap API
Attachments
Patch (2.97 KB, patch)
2011-04-27 15:59 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-04-27 15:59:53 PDT
Created attachment 91366 [details] Patch
Geoffrey Garen
Comment 2 2011-04-27 16:01:55 PDT
Comment on attachment 91366 [details] Patch r=me
WebKit Review Bot
Comment 3 2011-04-27 16:03:05 PDT
Attachment 91366 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSWeakObjectMapR..." exit_code: 1 Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h:86: The parameter name "map" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 4 2011-04-27 16:07:25 PDT
Committed r85117: <http://trac.webkit.org/changeset/85117>
WebKit Review Bot
Comment 5 2011-04-27 16:54:18 PDT
http://trac.webkit.org/changeset/85117 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.