Bug 59634

Summary:

Port Mozilla's IndexedDB tests: event.target.result after add() and put()

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dgrogan, fishd, hans, pilgrim, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Mark Pilgrim (Google)

Reported 2011-04-27 14:19:19 PDT

Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_key_requirements.html?force=1 This is a port of a test from Mozilla's IndexedDB test suite. It checks the value of event.target.result after the asynchronous add() and put() methods. WebKit passes this test.

Attachments
Patch (4.65 KB, patch) 2011-04-27 14:21 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Pilgrim (Google)

Comment 1 2011-04-27 14:21:17 PDT

Created attachment 91348 [details] Patch

David Grogan

Comment 2 2011-04-27 15:46:35 PDT

Comment on attachment 91348 [details] Patch r+ Mark, I'll let you set /cq?/

WebKit Commit Bot

Comment 3 2011-04-27 21:37:42 PDT

Comment on attachment 91348 [details] Patch Clearing flags on attachment: 91348 Committed r85148: <http://trac.webkit.org/changeset/85148>

WebKit Commit Bot

Comment 4 2011-04-27 21:37:47 PDT

All reviewed patches have been landed. Closing bug.

Tony Chang

Comment 5 2011-04-28 11:46:11 PDT

(In reply to comment #4) > All reviewed patches have been landed. Closing bug. This test is failing on the bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fmozilla%2Fkey-requirements.html&group=%40ToT%20-%20chromium.org Looks like the expected result is incorrect (the description is wrong). I'll land a fix.

Tony Chang

Comment 6 2011-04-28 11:48:38 PDT

Fixed expected result in http://trac.webkit.org/changeset/85217.

Mark Pilgrim (Google)

Comment 7 2011-04-28 11:49:17 PDT

Sorry about that. Thanks, Tony.

Note You need to log in before you can comment on or make changes to this bug.