Bug 59633

Summary: Work around currently-spurious ASSERT in WTF's random number generator for Chromium workers
Product: WebKit Reporter: Adam Klein <adamk>
Component: WebKit Misc.Assignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jianli, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Adam Klein
Reported 2011-04-27 14:18:45 PDT
The short story is that we want to remove these ASSERT's in Chromium's M12 branch. But the end goal is to fix this, for real, in a patch on 55728 by enabling WTF_MULTIPLE_THREADs. See https://bugs.webkit.org/show_bug.cgi?id=55728 and http://code.google.com/p/chromium/issues/detail?id=80713 for details.
Attachments
Patch (659 bytes, patch)
2011-04-27 14:24 PDT, Adam Klein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-04-27 14:24:04 PDT
Created attachment 91349 [details] Patch
Adam Klein
Comment 2 2011-04-27 14:25:09 PDT
Attached the patch I intend to apply to branches/chromium/742.
Adam Barth
Comment 3 2011-04-27 14:25:43 PDT
Comment on attachment 91349 [details] Patch Why are these threads spurious? We need to define JSC_MULTIPLE_THREADS if we using more than one thread. There's a bug about renaming it to WTF_MULTIPLE_THREADS
Adam Barth
Comment 4 2011-04-27 14:26:13 PDT
> Why are these threads spurious? ^^^ ASSERTS :)
Adam Barth
Comment 5 2011-04-27 14:26:48 PDT
Ah, I fail to read.
Adam Barth
Comment 6 2011-04-27 14:37:37 PDT
Comment on attachment 91349 [details] Patch r=me for the branch.
Adam Klein
Comment 7 2011-04-27 14:46:10 PDT
Committed as http://trac.webkit.org/changeset/85098 Closing bug.
Note You need to log in before you can comment on or make changes to this bug.