Bug 59625

Summary:

address aesthetic concerns for results.html format brought up at webkit meeting

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, mihaip, mjs, sam, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
screenshot	none
another screenshot	none
Patch	eric: review+, eric: commit-queue+

Ojan Vafai

Reported 2011-04-27 12:20:31 PDT

address aesthetic concerns for results.html format brought up at webkit meeting

Attachments
Patch (3.59 KB, patch) 2011-04-27 12:22 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
screenshot (22.82 KB, image/png) 2011-04-27 12:23 PDT, Ojan Vafai	no flags	Details
another screenshot (24.60 KB, image/png) 2011-04-27 12:25 PDT, Ojan Vafai	no flags	Details
Patch (4.04 KB, patch) 2011-04-27 12:26 PDT, Ojan Vafai	eric: review+ eric: commit-queue+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2011-04-27 12:22:01 PDT

Ojan Vafai

Comment 2 2011-04-27 12:23:34 PDT

Created attachment 91321 [details] screenshot It's much closer aesthetically to the old format now. The places where it differs are all functional.

Ojan Vafai

Comment 3 2011-04-27 12:25:01 PDT

Created attachment 91322 [details] another screenshot

Ojan Vafai

Comment 4 2011-04-27 12:26:38 PDT

Eric Seidel (no email)

Comment 5 2011-04-27 13:51:52 PDT

Comment on attachment 91323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91323&action=review OK. > LayoutTests/fast/harness/results.html:417 > +TableSorter._backwardArrow = '<svg style="width:10px;height:10px"><polygon points="0,10 10,10 5,0" style="fill:#ccc"></svg>'; omg. svg.

Ojan Vafai

Comment 6 2011-04-27 14:11:31 PDT

Note You need to log in before you can comment on or make changes to this bug.