Bug 59620

Summary:

Web Inspector: regression in inspector/console/console-dir.html after r85054

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

Web Inspector (Deprecated)

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

59611

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Second, Chromium-specific patch	none

Kenneth Russell

Reported 2011-04-27 10:52:12 PDT

http://trac.webkit.org/changeset/85054 has introduced a failure in layout test inspector/console/console-dir.html. It is possible the test simply needs to be rebaselined.

Attachments
Patch (1.57 KB, patch) 2011-04-27 11:08 PDT, Kenneth Russell	no flags	Details Formatted Diff Diff
Second, Chromium-specific patch (1.64 KB, patch) 2011-04-27 12:39 PDT, Kenneth Russell	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kenneth Russell

Comment 1 2011-04-27 11:06:11 PDT

I'm taking this one. It looks to me like a simple rebaseline is needed. The failure is identical on multiple ports.

Kenneth Russell

Comment 2 2011-04-27 11:08:55 PDT

Created attachment 91313 [details] Patch

Kenneth Russell

Comment 3 2011-04-27 11:09:40 PDT

Committed r85063: <http://trac.webkit.org/changeset/85063>

Kenneth Russell

Comment 4 2011-04-27 11:10:31 PDT

I've landed the attached rebaseline manually in order to get the tree green again. If that was the wrong thing to do, someone please reopen and take this bug. Thanks.

Kenneth Russell

Comment 5 2011-04-27 12:39:02 PDT

Reopening because I missed updating the chromium-specific test expectations.

Kenneth Russell

Comment 6 2011-04-27 12:39:50 PDT

Created attachment 91326 [details] Second, Chromium-specific patch

Kenneth Russell

Comment 7 2011-04-27 12:40:39 PDT

Committed r85073: <http://trac.webkit.org/changeset/85073>

Note You need to log in before you can comment on or make changes to this bug.