Bug 59614

Summary:

WK2 Mac client certificate authentication

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1	none
Patch v2 - Update alphabetization	none
Patch v3 - With WebCredential.mac.mm split off	none
Patch v4 - Removed all the cross platform ifdefness, even if Mac is the only user right now.	sam: review+

Brady Eidson

Reported 2011-04-27 09:11:37 PDT

WebKit2 on Mac needs the ability to authenticate with client certificates. In radar as <rdar://problem/8773946>

Attachments
Patch v1 (21.73 KB, patch) 2011-04-27 09:13 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v2 - Update alphabetization (21.71 KB, patch) 2011-04-27 09:42 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v3 - With WebCredential.mac.mm split off (24.44 KB, patch) 2011-04-28 09:33 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v4 - Removed all the cross platform ifdefness, even if Mac is the only user right now. (19.44 KB, patch) 2011-04-28 11:26 PDT, Brady Eidson	sam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2011-04-27 09:13:58 PDT

Created attachment 91296 [details] Patch v1

WebKit Review Bot

Comment 2 2011-04-27 09:17:20 PDT

Attachment 91296 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/UIProcess/API/C/mac/WKCredentialMac.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2011-04-27 09:42:13 PDT

Created attachment 91301 [details] Patch v2 - Update alphabetization

Jeff Miller

Comment 4 2011-04-28 07:08:46 PDT

Comment on attachment 91301 [details] Patch v2 - Update alphabetization View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review > Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49 > + I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here).

Brady Eidson

Comment 5 2011-04-28 09:27:59 PDT

(In reply to comment #4) > (From update of attachment 91301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review > > > Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49 > > + > > I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here). I think what you were trying to say was mac/WebCredential.mac.mm ;)

Brady Eidson

Comment 6 2011-04-28 09:28:17 PDT

And, not that much of a pain because it's just one project file change.

Brady Eidson

Comment 7 2011-04-28 09:33:14 PDT

Created attachment 91504 [details] Patch v3 - With WebCredential.mac.mm split off

Brady Eidson

Comment 8 2011-04-28 11:26:31 PDT

Created attachment 91524 [details] Patch v4 - Removed all the cross platform ifdefness, even if Mac is the only user right now.

Brady Eidson

Comment 9 2011-04-28 12:12:48 PDT

Landed in r85223

Note You need to log in before you can comment on or make changes to this bug.