| Summary: | WK2 Mac client certificate authentication | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
| Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brady Eidson
2011-04-27 09:11:37 PDT
Created attachment 91296 [details]
Patch v1
Attachment 91296 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/UIProcess/API/C/mac/WKCredentialMac.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 91301 [details]
Patch v2 - Update alphabetization
Comment on attachment 91301 [details] Patch v2 - Update alphabetization View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review > Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49 > + I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here). (In reply to comment #4) > (From update of attachment 91301 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91301&action=review > > > Source/WebKit2/UIProcess/Authentication/WebCredential.cpp:49 > > + > > I know it's a pain, but these member functions should really be put into a new mac/WebCredentialMac.cpp file (or mac/WebCredentialMac.mm, I'm not sure what our convention is here). I think what you were trying to say was mac/WebCredential.mac.mm ;) And, not that much of a pain because it's just one project file change. Created attachment 91504 [details]
Patch v3 - With WebCredential.mac.mm split off
Created attachment 91524 [details]
Patch v4 - Removed all the cross platform ifdefness, even if Mac is the only user right now.
|