Bug 59608

Summary:

Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2

Product:

WebKit

Reporter:

Young Han Lee <joybro201>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, eric, kbr, laszlo.gombos, skyul

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

47068

Attachments:

Description	Flags
Patch	none

Description Young Han Lee 2011-04-27 08:31:26 PDT

Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2

Comment 1 Young Han Lee 2011-04-27 08:33:29 PDT

Created attachment 91288 [details]
Patch

Comment 2 Young Han Lee 2011-04-27 08:36:09 PDT

TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h

Comment 3 Young Han Lee 2011-05-01 09:14:27 PDT

Is there anybody who can review this patch?
This bug is very obvious and causes compile error in OPENGLES environment.

>:~/Works/WebKit/Source/WebCore/platform$ grep -R TEXMAP_OPENGL_ES *
graphics/opengl/TextureMapperGL.cpp:#if defined(TEXMAP_OPENGL_ES_2)
graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2
graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2
graphics/texmap/TextureMapper.h:    #if defined(QT_OPENGL_ES_2) && !defined(TEXMAP_OPENGL_ES_2)
graphics/texmap/TextureMapper.h:        #define TEXMAP_OPENGL_ES_2

Comment 4 Eric Seidel (no email) 2011-05-01 09:40:32 PDT

Comment on attachment 91288 [details]
Patch

Looks reasonable.

Comment 5 WebKit Commit Bot 2011-05-01 10:25:43 PDT

Comment on attachment 91288 [details]
Patch

Clearing flags on attachment: 91288

Committed r85417: <http://trac.webkit.org/changeset/85417>

Comment 6 WebKit Commit Bot 2011-05-01 10:25:48 PDT

All reviewed patches have been landed.  Closing bug.