Bug 59608

Summary: Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
Product: WebKit Reporter: Young Han Lee <joybro201>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, eric, kbr, laszlo.gombos, skyul
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 47068    
Attachments:
Description Flags
Patch none

Young Han Lee
Reported 2011-04-27 08:31:26 PDT
Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
Attachments
Patch (1.61 KB, patch)
2011-04-27 08:33 PDT, Young Han Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Young Han Lee
Comment 1 2011-04-27 08:33:29 PDT
Created attachment 91288 [details] Patch
Young Han Lee
Comment 2 2011-04-27 08:36:09 PDT
TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
Young Han Lee
Comment 3 2011-05-01 09:14:27 PDT
Is there anybody who can review this patch? This bug is very obvious and causes compile error in OPENGLES environment. >:~/Works/WebKit/Source/WebCore/platform$ grep -R TEXMAP_OPENGL_ES * graphics/opengl/TextureMapperGL.cpp:#if defined(TEXMAP_OPENGL_ES_2) graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2 graphics/opengl/TextureMapperGL.cpp:#ifndef TEXMAP_OPENGL_ES2 graphics/texmap/TextureMapper.h: #if defined(QT_OPENGL_ES_2) && !defined(TEXMAP_OPENGL_ES_2) graphics/texmap/TextureMapper.h: #define TEXMAP_OPENGL_ES_2
Eric Seidel (no email)
Comment 4 2011-05-01 09:40:32 PDT
Comment on attachment 91288 [details] Patch Looks reasonable.
WebKit Commit Bot
Comment 5 2011-05-01 10:25:43 PDT
Comment on attachment 91288 [details] Patch Clearing flags on attachment: 91288 Committed r85417: <http://trac.webkit.org/changeset/85417>
WebKit Commit Bot
Comment 6 2011-05-01 10:25:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.