Summary: | [GTK] WKView should be a GtkWidget | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, mrobinson, xan.lopez | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 59594 | ||||||||
Bug Blocks: | 57944 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-04-27 05:10:06 PDT
Created attachment 91274 [details]
Patch
Created attachment 91440 [details]
New patch
As martin poined out, we don't need a new class inheriting from WebKitWebViewBase, we can simply map WKViewRef to WebKitWebViewBase. So this patch leaves WebKitWebViewBase as a non-abstract class and makes WKViewCreate return the widget instead of the page client so that WKView can be used as a widget.
Committed r85192: <http://trac.webkit.org/changeset/85192> |