Bug 59603

Summary: [GTK] WKView should be a GtkWidget
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: eric, mrobinson, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 59594    
Bug Blocks: 57944    
Description Flags
New patch none

Description Carlos Garcia Campos 2011-04-27 05:10:06 PDT
This way, the use of WebKitWebBase will be transparent for the C API and we can get rid of WKViewGetWindow() which is very confusing because it doesn't return a window, but a GtkWidget that is indeed the view.
Comment 1 Carlos Garcia Campos 2011-04-27 05:30:53 PDT
Created attachment 91274 [details]
Comment 2 Carlos Garcia Campos 2011-04-28 00:33:26 PDT
Created attachment 91440 [details]
New patch

As martin poined out, we don't need a new class inheriting from WebKitWebViewBase, we can simply map WKViewRef to WebKitWebViewBase. So this patch leaves WebKitWebViewBase as a non-abstract class and makes WKViewCreate return the widget instead of the page client so that WKView can be used as a widget.
Comment 3 Carlos Garcia Campos 2011-04-28 09:29:09 PDT
Committed r85192: <http://trac.webkit.org/changeset/85192>