Bug 59601 – [GTK] Do not initialize wep application database if it was disabled at configure time.

• Component: New Bugs
• Status: RESOLVED INVALID

[Alexandre Mazari]

[GTK] Do not initialize wep application database if it was disabled at configure time.

[Alexandre Mazari]

Created attachment 91270 [details]
Patch

[Martin Robinson]

Comment on attachment 91270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91270&action=review

Very nice. One small suggestion below.

> Source/WebKit/gtk/webkit/webkitglobals.cpp:271
>      gchar* databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL);
>      webkit_set_web_database_directory_path(databaseDirectory);
>      WebCore::cacheStorage().setCacheDirectory(databaseDirectory);
>  
>      g_free(databaseDirectory);

Please switch to using GOwnPtr for databaseDirectory:

GOwnPtr<gchar> databaseDirectory = g_build_filename(g_get_user_data_dir(), "webkit", "databases", NULL);
webkit_set_web_database_directory_path(databaseDirectory.get());
WebCore::cacheStorage().setCacheDirectory(databaseDirectory.get());

[Philippe Normand]

Is this patch still relevant, Alex?

[Philippe Normand]

databaseDirectory now uses GOwnPtr and I don't think those calls need to be guarded by ENABLE(DATABASE), the webkit_set_web_database_directory_path function is already guarded by  ENABLE(SQL_DATABASE).

WebCore::cacheStorage().setCacheDirectory() doesn't need guards either, afaict.

Closing this bug, feel free to reopen if needed :)