Bug 59593

Summary: Web Inspector: provide a hotkey for script pause
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested fix yurys: review+

Yury Semikhatsky
Reported 2011-04-27 03:10:25 PDT
We have hotkeys for stepping and continue, it looks logical to have one for script pause. There is a user request for this: http://groups.google.com/a/chromium.org/group/chromium-discuss/browse_thread/thread/c5bde640f8281002/63410885d71aef6d
Attachments
[PATCH] Suggested fix (2.03 KB, patch)
2011-04-28 04:31 PDT, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-04-28 00:59:25 PDT
F8 is the key, as it is bound to the Pause/Continue button click handler. If the same key for the two actions is deemed OK, we just need to update the shortcuts help page.
Alexander Pavlov (apavlov)
Comment 2 2011-04-28 04:31:06 PDT
Created attachment 91471 [details] [PATCH] Suggested fix This fixes the shortcuts help page for F8.
WebKit Review Bot
Comment 3 2011-04-28 04:34:00 PDT
Attachment 91471 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexander Pavlov (apavlov)
Comment 4 2011-04-28 06:03:47 PDT
Committed r85179: <http://trac.webkit.org/changeset/85179>
Note You need to log in before you can comment on or make changes to this bug.