Bug 59575
| Summary: | sheriff-bot create-bug command files bug with a wrong reporter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ddkilzer, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Alexey Proskuryakov
Sheriff bot files bugs using commit queue account. You need to scroll down and find the reporter e-mail address in a comment (where it's not highlighted). This is quite annoying. Also, the Reporter field is sent in RSS feeds, but comments aren't.
Since many people are going to read a bug, and filing it is a one-time act, I'm not sure if any time is saved for project contributors as a group.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
See also: bug 59545. Would it make sense to roll out the patch from bug 59491 until these are resolved?
Eric Seidel (no email)
I've posted a fix to bug 59545.
I don't know any way to fix this. We can certainly make the requester much more obvious in the description (or even in the bug title). But I don't know any way to change the reporter of a bug once created.
Eric Seidel (no email)
I wonder if what is mentioned in this redhat bugzilla comment is possible:
https://bugzilla.redhat.com/show_bug.cgi?id=432238#c1
Eric Seidel (no email)
I don't see any way to change the reporter in http://trac.webkit.org/browser/trunk/Websites/bugs.webkit.org/process_bug.cgi (which is the form that bugzilla posts when editing a bug).
Eric Seidel (no email)
If we found a way to fix this, we could easily fix this for all bugs that sheriff-bot creates. Including the rollout bugs (which are currently much more common than the new create-bug bugs).
Eric Seidel (no email)
The sheriff-bot currently files all bugs (rollouts as well as these new create-bug bugs) as webkit.review.bot@gmail.com. Which is one account which is shared between many of the EWS bots and the sheriff-bot.
I'm happy to get him his own account (sheriff-bot@webkit.org?) if that would make this any better.
Eric Seidel (no email)
The sheriff-bot has failed a total of 581 bugs so far in its lifetime:
https://bugs.webkit.org/buglist.cgi?query_format=advanced&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&emailreporter1=1&emailtype1=substring&email1=webkit.review.bot%40gmail.com
Alexey Proskuryakov
> I'm happy to get him his own account (sheriff-bot@webkit.org?) if that would make this any better.
I don't think that would be a significant change.
Looking at the bugs filed by sheriffbot, I think that they are generally of lower quality than it used to be common for the project. They don't even have a component set.
Eric Seidel (no email)
(In reply to comment #8)
> > I'm happy to get him his own account (sheriff-bot@webkit.org?) if that would make this any better.
>
> I don't think that would be a significant change.
>
> Looking at the bugs filed by sheriffbot, I think that they are generally of lower quality than it used to be common for the project. They don't even have a component set.
I'm happy to implement suggested ways to improve the quality of bugs filed by any of our tools.
For example, I'd be happy to have rollout bugs copy the component from the bug they're rolling out if that would be of help?
Alexey Proskuryakov
That sounds like a neat idea.
Personally, I don't care about rollout bugs much - they are not something many people are going to read, and it is obvious from the title what kind of bugs those are. But filing new real bugs from a single line command in chat doesn't seem so great.