Bug 59560

Summary: Frame.h shouldn't include Document.h
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Layout and RenderingAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihai Parparita
Reported 2011-04-26 16:47:32 PDT
Frame.h shouldn't include Document.h
Attachments
Patch (3.39 KB, patch)
2011-04-26 17:00 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.43 KB, patch)
2011-04-26 20:37 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2011-04-26 17:00:04 PDT
Created attachment 91184 [details] Patch
WebKit Review Bot
Comment 2 2011-04-26 17:02:26 PDT
Attachment 91184 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/Frame.h:64: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 3 2011-04-26 17:15:28 PDT
Comment on attachment 91184 [details] Patch Yay!
WebKit Review Bot
Comment 4 2011-04-26 17:17:41 PDT
Attachment 91184 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8508803
Mihai Parparita
Comment 5 2011-04-26 17:41:16 PDT
Comment on attachment 91184 [details] Patch Will look into the Chromium failure.
Mihai Parparita
Comment 6 2011-04-26 20:37:31 PDT
Created attachment 91222 [details] Patch for landing
WebKit Review Bot
Comment 7 2011-04-26 20:45:24 PDT
Attachment 91184 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8509829
WebKit Commit Bot
Comment 8 2011-04-27 00:37:15 PDT
Comment on attachment 91222 [details] Patch for landing Clearing flags on attachment: 91222 Committed r85030: <http://trac.webkit.org/changeset/85030>
WebKit Commit Bot
Comment 9 2011-04-27 00:37:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.