Bug 59560 - Frame.h shouldn't include Document.h
Summary: Frame.h shouldn't include Document.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-26 16:47 PDT by Mihai Parparita
Modified: 2011-04-27 00:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2011-04-26 17:00 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff
Patch for landing (16.43 KB, patch)
2011-04-26 20:37 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2011-04-26 16:47:32 PDT
Frame.h shouldn't include Document.h
Comment 1 Mihai Parparita 2011-04-26 17:00:04 PDT
Created attachment 91184 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-26 17:02:26 PDT
Attachment 91184 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/Frame.h:64:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Seidel (no email) 2011-04-26 17:15:28 PDT
Comment on attachment 91184 [details]
Patch

Yay!
Comment 4 WebKit Review Bot 2011-04-26 17:17:41 PDT
Attachment 91184 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8508803
Comment 5 Mihai Parparita 2011-04-26 17:41:16 PDT
Comment on attachment 91184 [details]
Patch

Will look into the Chromium failure.
Comment 6 Mihai Parparita 2011-04-26 20:37:31 PDT
Created attachment 91222 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-04-26 20:45:24 PDT
Attachment 91184 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8509829
Comment 8 WebKit Commit Bot 2011-04-27 00:37:15 PDT
Comment on attachment 91222 [details]
Patch for landing

Clearing flags on attachment: 91222

Committed r85030: <http://trac.webkit.org/changeset/85030>
Comment 9 WebKit Commit Bot 2011-04-27 00:37:20 PDT
All reviewed patches have been landed.  Closing bug.