Bug 59545 – sherrifbot create-bug shouldn't assign bugs to webkit.review.bot

• Component: Tools / Tests
• Status: RESOLVED FIXED

[WebKit Review Bot]

sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
Requested by aroben on #webkit.

[Alexey Proskuryakov]

See also: bug 59575.

[Eric Seidel (no email)]

Created attachment 91240 [details]
Patch

[Mihai Parparita]

Comment on attachment 91240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91240&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:391
> +            if contributor.full_name and contributor.full_name == name:

Why the check if contributor.full_name is non-empty? Presumably the name argument will be non-empty, so the equality check should take care of that.

> Tools/Scripts/webkitpy/common/config/committers.py:400
> +            if contributor.irc_nickname and contributor.irc_nickname == irc_nickname:

Ditto here.

> Tools/Scripts/webkitpy/common/config/committers.py:404
> +    def contributor_by_email(self, email):

Now that you have this, perhaps the committer_by_email call in the whois command should also be changed to support contributors?

[Eric Seidel (no email)]

(In reply to comment #3)
> (From update of attachment 91240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91240&action=review
> 
> > Tools/Scripts/webkitpy/common/config/committers.py:391
> > +            if contributor.full_name and contributor.full_name == name:
> 
> Why the check if contributor.full_name is non-empty? Presumably the name argument will be non-empty, so the equality check should take care of that.

Originally I added an assert(name) to that function.  However, current code violates that.  (Which is OK, since full_name can never be empty.)  I wanted to make sure that future code didn't end up allowing None full_name and causing this function to do strange things.

> > Tools/Scripts/webkitpy/common/config/committers.py:400
> > +            if contributor.irc_nickname and contributor.irc_nickname == irc_nickname:
> 
> Ditto here.

None is a valid value for irc_nickname however.  But it doesn't make sense to search for a none nickname.  I could assert that argument irc_nickname is never None, but that seemed to be confusing when compared with contributor_by_name().

> > Tools/Scripts/webkitpy/common/config/committers.py:404
> > +    def contributor_by_email(self, email):
> 
> Now that you have this, perhaps the committer_by_email call in the whois command should also be changed to support contributors?

Happy to make that change!

[Eric Seidel (no email)]

Created attachment 91290 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 91291 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 91291 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 91291 [details]
Patch for landing

Clearing flags on attachment: 91291

Committed r85065: <http://trac.webkit.org/changeset/85065>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.