Summary: | InlineBox.h shouldn't include RenderBR.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||
Component: | Layout and Rendering | Assignee: | Mihai Parparita <mihaip> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, thakis | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Mihai Parparita
2011-04-26 12:05:04 PDT
Created attachment 91141 [details]
Patch
Cool! You could add something like "this reduces the size of InlineBox.h by XXX kB" to the ChangeLog entry. You get the XXX from eric's script attached to bug 59348. Before: Source/WebCore/rendering/InlineBox.h: 0.917 247 226.499000 (from bug 59348) After: Source/WebCore/rendering/InlineBox.h: 0.906 247 223.782000 So it's only 11K in the .h file, and 3MB across all the includes? Looks like it. Probably because InlineBox.h and RenderBR.h include similar files. :-/ Comment on attachment 91141 [details] Patch Clearing flags on attachment: 91141 Committed r84956: <http://trac.webkit.org/changeset/84956> All reviewed patches have been landed. Closing bug. |