Bug 59472

Summary: Port Mozilla's IndexedDB tests: index cursors
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, fishd, hans, pilgrim, tony
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch with changelog and layouttest
none
Patch none

Mark Pilgrim (Google)
Reported 2011-04-26 11:14:37 PDT
Original tests: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_objectCursors.html?force=1 This is a pair of tests ported from Mozilla's IndexedDB test suite. It checks some basic properties of index cursors. WebKit passes these tests.
Attachments
patch with changelog and layouttest (9.43 KB, patch)
2011-04-26 11:21 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (6.06 KB, patch)
2011-04-27 13:32 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-04-26 11:21:45 PDT
Created attachment 91130 [details] patch with changelog and layouttest
Tony Chang
Comment 2 2011-04-26 16:28:18 PDT
Comment on attachment 91130 [details] patch with changelog and layouttest View in context: https://bugs.webkit.org/attachment.cgi?id=91130&action=review I suspect the bot will have a hard time landing these patches since the root of the diff isn't the root of the webkit repo. > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors-autoincrement.html:20 > +description("Test IndexedDB's index cursors"); Nit: Should this mention autoincrement (to help differentiate it from object-cursors.html)? > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors.html:1 > +<!DOCTYPE html> These tests look almost identical. Can we make it into a single test file to avoid the code repetition?
Mark Pilgrim (Google)
Comment 3 2011-04-27 13:32:25 PDT
Created attachment 91335 [details] Patch
Mark Pilgrim (Google)
Comment 4 2011-04-27 13:36:29 PDT
I believe this patch is now rooted properly. I combined the two tests into one file and added logged autoIncrement=true/false statements to differentiate between the tests.
WebKit Commit Bot
Comment 5 2011-04-27 21:56:06 PDT
Comment on attachment 91335 [details] Patch Clearing flags on attachment: 91335 Committed r85150: <http://trac.webkit.org/changeset/85150>
WebKit Commit Bot
Comment 6 2011-04-27 21:56:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.