Summary: | Port Mozilla's IndexedDB tests: index cursors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dgrogan, fishd, hans, pilgrim, tony | ||||||
Priority: | P3 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-04-26 11:14:37 PDT
Created attachment 91130 [details]
patch with changelog and layouttest
Comment on attachment 91130 [details] patch with changelog and layouttest View in context: https://bugs.webkit.org/attachment.cgi?id=91130&action=review I suspect the bot will have a hard time landing these patches since the root of the diff isn't the root of the webkit repo. > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors-autoincrement.html:20 > +description("Test IndexedDB's index cursors"); Nit: Should this mention autoincrement (to help differentiate it from object-cursors.html)? > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors.html:1 > +<!DOCTYPE html> These tests look almost identical. Can we make it into a single test file to avoid the code repetition? Created attachment 91335 [details]
Patch
I believe this patch is now rooted properly. I combined the two tests into one file and added logged autoIncrement=true/false statements to differentiate between the tests. Comment on attachment 91335 [details] Patch Clearing flags on attachment: 91335 Committed r85150: <http://trac.webkit.org/changeset/85150> All reviewed patches have been landed. Closing bug. |