Bug 59464

Summary:

Fix more strict OwnPtr in WebCore (round N).

Product:

WebKit

Reporter:

David Levin <levin>

Component:

New Bugs

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	darin: review+

Description David Levin 2011-04-26 09:22:56 PDT

Fix more strict OwnPtr in WebCore (round N).

Comment 1 David Levin 2011-04-26 09:23:26 PDT

Created attachment 91117 [details]
Patch

Comment 2 Darin Adler 2011-04-26 09:48:52 PDT

Comment on attachment 91117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91117&action=review

> Source/WebCore/fileapi/FileReader.cpp:171
> -        m_loader = 0;
> +        m_loader.clear();

Anders Carlsson would much prefer that we use "= nullptr" rather than "clear()".

> Source/WebCore/loader/DocumentThreadableLoader.cpp:334
> -    m_actualRequest = 0; // Prevent didFinishLoading() from bypassing access check.
> +    m_actualRequest.clear(); // Prevent didFinishLoading() from bypassing access check.

Ditto.

Comment 3 David Levin 2011-04-26 10:17:13 PDT

Committed as http://trac.webkit.org/changeset/84923