Summary: | Web Inspector: implement incremental CSS editing in the structure view. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2011-04-26 07:44:35 PDT
Created attachment 91105 [details]
Patch
Comment on attachment 91105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 > + if (this._handleUpOrDownKeyPressed(event)) A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally). Comment on attachment 91105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review >> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 >> + if (this._handleUpOrDownKeyPressed(event)) > > A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally). I think increments should be processed synchronously, with no delay Comment on attachment 91105 [details] Patch Clearing flags on attachment: 91105 Committed r85034: <http://trac.webkit.org/changeset/85034> All reviewed patches have been landed. Closing bug. |