| Summary: | Web Inspector: New Style is not working (UI glitch) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Feldman
2011-04-26 06:07:17 PDT
Created attachment 91096 [details]
Patch
Created attachment 91098 [details]
Patch
Comment on attachment 91098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91098&action=review > Source/WebCore/inspector/front-end/CSSStyleModel.js:185 > + var documentElement = node && node.ownerDocumentElement(); is it possible that ownerDocumentElement is undefined? if not prefer early return Committed r84909: <http://trac.webkit.org/changeset/84909> http://trac.webkit.org/changeset/84909 might have broken SnowLeopard Intel Release (Tests) (In reply to comment #5) > http://trac.webkit.org/changeset/84909 might have broken SnowLeopard Intel Release (Tests) And Qt and I think other bots too. --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/inspector-enabled/dom-storage-open-expected.txt 2011-04-26 07:46:48.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/inspector-enabled/dom-storage-open-actual.txt 2011-04-26 07:46:48.000000000 -0700 @@ -1,5 +1 @@ Tests that Web Inspector gets populated with DOM storages that were opened before inspector is shown. - -Domain: 127.0.0.1 -IsLocalStorage: false - |