| Summary: | [Qt] Implement LayoutTestController::setAutofilled | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kristóf Kosztyó <kkristof> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ossy, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Kristóf Kosztyó
2011-04-26 02:44:37 PDT
Created attachment 91090 [details]
proposed fix
Attachment 91090 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.h:112: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5]
Tools/DumpRenderTree/qt/LayoutTestControllerQt.h:154: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 91093 [details]
proposed fix
Comment on attachment 91093 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=91093&action=review LGTM, r=me. (Apart from some minor thing, what I'll fix before landing.) > LayoutTests/platform/qt/Skipped:-723 > -# Missing layoutTestController.overridePreference() > -fast/events/pageshow-pagehide-on-back-cached.html > -fast/events/pageshow-pagehide-on-back-cached-with-frames.html > - This change is unrelated to this bug. > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:246 > + return; Add a newline after it. Comment on attachment 91093 [details] proposed fix Landed in http://trac.webkit.org/changeset/84906 |