Bug 59425

Summary:

Nixed special finalizer handling for WebCore strings

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mjs, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	oliver: review+

Description Geoffrey Garen 2011-04-25 23:31:45 PDT

Nixed special finalizer handling for WebCore strings

Comment 1 Geoffrey Garen 2011-04-25 23:44:42 PDT

Created attachment 91071 [details]
Patch

Comment 2 Oliver Hunt 2011-04-26 08:11:49 PDT

Comment on attachment 91071 [details]
Patch

I believe that it should be possible to do this with a WeakGCMap directly rather than switching to the less efficient hashmap<weak> model

Comment 3 Oliver Hunt 2011-04-26 08:40:18 PDT

No I was wrong, although I'm not sure why I don't have it supported (i have most of what's need, just not an actual finalizer call).  It would be trivial to add a custom finalizer.

Comment 4 Oliver Hunt 2011-04-26 11:22:55 PDT

Comment on attachment 91071 [details]
Patch

There's less thrashing in HashMap<Weak> than i thought,  so this is fine

Comment 5 Geoffrey Garen 2011-04-26 11:31:08 PDT

Committed r84934: <http://trac.webkit.org/changeset/84934>