Bug 59425

Summary: Nixed special finalizer handling for WebCore strings
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch oliver: review+

Geoffrey Garen
Reported 2011-04-25 23:31:45 PDT
Nixed special finalizer handling for WebCore strings
Attachments
Patch (17.64 KB, patch)
2011-04-25 23:44 PDT, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-04-25 23:44:42 PDT
Created attachment 91071 [details] Patch
Oliver Hunt
Comment 2 2011-04-26 08:11:49 PDT
Comment on attachment 91071 [details] Patch I believe that it should be possible to do this with a WeakGCMap directly rather than switching to the less efficient hashmap<weak> model
Oliver Hunt
Comment 3 2011-04-26 08:40:18 PDT
No I was wrong, although I'm not sure why I don't have it supported (i have most of what's need, just not an actual finalizer call). It would be trivial to add a custom finalizer.
Oliver Hunt
Comment 4 2011-04-26 11:22:55 PDT
Comment on attachment 91071 [details] Patch There's less thrashing in HashMap<Weak> than i thought, so this is fine
Geoffrey Garen
Comment 5 2011-04-26 11:31:08 PDT
Committed r84934: <http://trac.webkit.org/changeset/84934>
Note You need to log in before you can comment on or make changes to this bug.