| Summary: | Turn off make built-in implicit rules for derived sources makefile | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||||
| Component: | Tools / Tests | Assignee: | Mihai Parparita <mihaip> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, evan, mrowe | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | OS X 10.6 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mihai Parparita
2011-04-25 22:33:13 PDT
Created attachment 91055 [details]
Patch
Seems to make the biggest difference (a couple of seconds) for Source/WebCore/DerivedSources.make. I'm confused as to what this does? Comment on attachment 91055 [details]
Patch
Any reason why the -r is at the end of the line? I would have put it near the beginning, but I'm not sure it matters.
-r, --no-builtin-rules
Eliminate use of the built-in implicit rules. Also clear out the
default list of suffixes for suffix rules.
Maybe use the expanded form so folks who aren't make experts will understand later? (In reply to comment #3) > I'm confused as to what this does? GNU make has a bunch of implicit rules: http://www.gnu.org/software/make/manual/make.html#Catalogue-of-Rules. See "In porting our build to Make I learned a lot about it" paragraph from http://neugierig.org/software/chromium/notes/2011/02/ninja.html (In reply to comment #6) > Maybe use the expanded form so folks who aren't make experts will understand later? Will do. Created attachment 91059 [details]
Patch for landing
Comment on attachment 91059 [details] Patch for landing Clearing flags on attachment: 91059 Committed r84900: <http://trac.webkit.org/changeset/84900> All reviewed patches have been landed. Closing bug. |