RESOLVED FIXED59418
Turn off make built-in implicit rules for derived sources makefile 
https://bugs.webkit.org/show_bug.cgi?id=59418
Summary Turn off make built-in implicit rules for derived sources makefile
Mihai Parparita
Reported 2011-04-25 22:33:13 PDT
Turn off make built-in implicit rules for derived sources makefile
Attachments
Patch (7.27 KB, patch)
2011-04-25 22:34 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.34 KB, patch)
2011-04-25 22:55 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2011-04-25 22:34:44 PDT
Created attachment 91055 [details] Patch
Mihai Parparita
Comment 2 2011-04-25 22:36:16 PDT
Seems to make the biggest difference (a couple of seconds) for Source/WebCore/DerivedSources.make.
Eric Seidel (no email)
Comment 3 2011-04-25 22:44:23 PDT
I'm confused as to what this does?
Adam Barth
Comment 4 2011-04-25 22:45:38 PDT
Comment on attachment 91055 [details] Patch Any reason why the -r is at the end of the line? I would have put it near the beginning, but I'm not sure it matters.
Adam Barth
Comment 5 2011-04-25 22:46:04 PDT
-r, --no-builtin-rules Eliminate use of the built-in implicit rules. Also clear out the default list of suffixes for suffix rules.
Adam Barth
Comment 6 2011-04-25 22:46:33 PDT
Maybe use the expanded form so folks who aren't make experts will understand later?
Mihai Parparita
Comment 7 2011-04-25 22:49:17 PDT
(In reply to comment #3) > I'm confused as to what this does? GNU make has a bunch of implicit rules: http://www.gnu.org/software/make/manual/make.html#Catalogue-of-Rules. See "In porting our build to Make I learned a lot about it" paragraph from http://neugierig.org/software/chromium/notes/2011/02/ninja.html
Mihai Parparita
Comment 8 2011-04-25 22:49:34 PDT
(In reply to comment #6) > Maybe use the expanded form so folks who aren't make experts will understand later? Will do.
Mihai Parparita
Comment 9 2011-04-25 22:55:57 PDT
Created attachment 91059 [details] Patch for landing
WebKit Commit Bot
Comment 10 2011-04-26 03:08:26 PDT
Comment on attachment 91059 [details] Patch for landing Clearing flags on attachment: 91059 Committed r84900: <http://trac.webkit.org/changeset/84900>
WebKit Commit Bot
Comment 11 2011-04-26 03:08:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.