Bug 59416 – Fix timestamp comparison in check-for-weak-vtables-and-externals

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mihai Parparita]

Fix timestamp comparison in check-for-weak-vtables-and-externals

[Mihai Parparita]

Created attachment 91052 [details]
Patch

[Mihai Parparita]

Seems to shave a couple of seconds off a no-op build on my 12 core Mac Pro (currently at 21 seconds).

[Eric Seidel (no email)]

Comment on attachment 91052 [details]
Patch

Yay!  What about the exit-time-destructors you were mentioning today?

[Mihai Parparita]

(In reply to comment #3)
> (From update of attachment 91052 [details])
> Yay!  What about the exit-time-destructors you were mentioning today?

I think I got that mixed up with this script; it seems to behave as expected.

[WebKit Commit Bot]

Comment on attachment 91052 [details]
Patch

Rejecting attachment 91052 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1

Last 500 characters of output:
  return self.open(self.click(*args, **kwds))
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://queues.webkit.org/results/8510508

[WebKit Commit Bot]

Comment on attachment 91052 [details]
Patch

Clearing flags on attachment: 91052

Committed r84912: <http://trac.webkit.org/changeset/84912>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.