| Summary: | Fix timestamp comparison in check-for-weak-vtables-and-externals | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mihai Parparita <mihaip> | ||||
| Component: | Tools / Tests | Assignee: | Mihai Parparita <mihaip> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben, commit-queue, darin, eric | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Mihai Parparita
2011-04-25 21:39:19 PDT
Created attachment 91052 [details]
Patch
Seems to shave a couple of seconds off a no-op build on my 12 core Mac Pro (currently at 21 seconds). Comment on attachment 91052 [details]
Patch
Yay! What about the exit-time-destructors you were mentioning today?
(In reply to comment #3) > (From update of attachment 91052 [details]) > Yay! What about the exit-time-destructors you were mentioning today? I think I got that mixed up with this script; it seems to behave as expected. Comment on attachment 91052 [details] Patch Rejecting attachment 91052 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/8510508 Comment on attachment 91052 [details] Patch Clearing flags on attachment: 91052 Committed r84912: <http://trac.webkit.org/changeset/84912> All reviewed patches have been landed. Closing bug. |