Bug 59389

Summary: Make a couple of animation tests into text tests
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dbates: review+

Simon Fraser (smfr)
Reported 2011-04-25 16:25:24 PDT
Make a couple of animation tests into text tests
Attachments
Patch (51.37 KB, patch)
2011-04-25 16:26 PDT, Simon Fraser (smfr) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-04-25 16:26:38 PDT
Created attachment 91001 [details] Patch
Daniel Bates
Comment 2 2011-04-25 16:31:35 PDT
Comment on attachment 91001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91001&action=review > LayoutTests/animations/animation-drt-api-multiple-keyframes.html:5 > + <style type="text/css"> Nit: This can be shortened to <style>. > LayoutTests/animations/animation-drt-api-multiple-keyframes.html:25 > + <script src="resources/animation-test-helpers.js" type="text/javascript"></script> > + <script type="text/javascript"> Nit: The type attribute is unnecessary.
Daniel Bates
Comment 3 2011-04-25 16:32:28 PDT
You're missing the expected results. Also, we could use the fast/js/resources scripts instead of doing this output by hand.
Simon Fraser (smfr)
Comment 4 2011-04-25 20:19:14 PDT
https://trac.webkit.org/changeset/84873
WebKit Review Bot
Comment 5 2011-04-25 21:03:56 PDT
http://trac.webkit.org/changeset/84873 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: compositing/animation/computed-style-during-delay.html compositing/reflections/animation-inside-reflection.html compositing/reflections/nested-reflection-animated.html compositing/reflections/nested-reflection-transition.html compositing/transitions/scale-transition-no-start.html compositing/transitions/singular-scale-transition.html
Note You need to log in before you can comment on or make changes to this bug.