Bug 59382

Summary:

WebCore/css/CSS* files should play nice with strict OwnPtrs

Product:

WebKit

Reporter:

Adrienne Walker <enne>

Component:

New Bugs

Assignee:

Adrienne Walker <enne>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, enne, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	levin: review+

Adrienne Walker

Reported 2011-04-25 16:15:31 PDT

WebCore/css/CSS* files should play nice with strict OwnPtrs

Attachments
Patch (4.64 KB, patch) 2011-04-25 16:16 PDT, Adrienne Walker	levin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adrienne Walker

Comment 1 2011-04-25 16:16:31 PDT

Created attachment 90988 [details] Patch

David Levin

Comment 2 2011-04-25 16:20:04 PDT

Comment on attachment 90988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90988&action=review two nits to fix. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Fix this :) > Source/WebCore/css/CSSFontFaceSource.cpp:167 > fontDescription.textOrientation(), fontDescription.widthVariant(), fontDescription.renderingMode()), true, false)); This should be indented further.

Adrienne Walker

Comment 3 2011-04-25 16:37:01 PDT

Committed r84836: <http://trac.webkit.org/changeset/84836>

WebKit Review Bot

Comment 4 2011-04-25 16:41:44 PDT

http://trac.webkit.org/changeset/84836 might have broken Chromium Linux Release

Note You need to log in before you can comment on or make changes to this bug.