Bug 59375

Summary:

Fix strict OwnPtrs in ContextMenuController.cpp

Product:

WebKit

Reporter:

David Levin <levin>

Component:

New Bugs

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	kbr: review+

Description David Levin 2011-04-25 16:07:44 PDT

Fix strict OwnPtrs in ContextMenuController.cpp

Comment 1 David Levin 2011-04-25 16:08:36 PDT

Created attachment 90980 [details]
Patch

Comment 2 Adam Barth 2011-04-25 16:10:05 PDT

Comment on attachment 90980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90980&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

OOPS!

> Source/WebCore/page/ContextMenuController.cpp:126
> -        return 0;
> +        return adoptPtr<ContextMenu>(0);

PassOwnPtr<ContextMenu>()

Comment 3 David Levin 2011-04-25 16:13:37 PDT

Created attachment 90985 [details]
Patch

Comment 4 Kenneth Russell 2011-04-25 16:15:11 PDT

Comment on attachment 90985 [details]
Patch

Looks good to me.

Comment 5 David Levin 2011-04-26 00:32:30 PDT

Committed as http://trac.webkit.org/changeset/84829