Bug 59375 - Fix strict OwnPtrs in ContextMenuController.cpp
Summary: Fix strict OwnPtrs in ContextMenuController.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-25 16:07 PDT by David Levin
Modified: 2011-04-26 00:32 PDT (History)
0 users

See Also:

Attachments
Patch (2.29 KB, patch)
2011-04-25 16:08 PDT, David Levin 		no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2011-04-25 16:13 PDT, David Levin 		kbr: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-04-25 16:07:44 PDT 
Fix strict OwnPtrs in ContextMenuController.cpp
Comment 1 David Levin 2011-04-25 16:08:36 PDT 
Created attachment 90980 [details]
Patch
Comment 2 Adam Barth 2011-04-25 16:10:05 PDT 
Comment on attachment 90980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90980&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

OOPS!

> Source/WebCore/page/ContextMenuController.cpp:126
> -        return 0;
> +        return adoptPtr<ContextMenu>(0);

PassOwnPtr<ContextMenu>()
Comment 3 David Levin 2011-04-25 16:13:37 PDT 
Created attachment 90985 [details]
Patch
Comment 4 Kenneth Russell 2011-04-25 16:15:11 PDT 
Comment on attachment 90985 [details]
Patch

Looks good to me.
Comment 5 David Levin 2011-04-26 00:32:30 PDT 
Committed as http://trac.webkit.org/changeset/84829