Bug 59372

Summary: Restore user default for enabling HTTP pipelining
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Page LoadingAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, joepeck, koivisto, mitz, psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch koivisto: review+

Description David Kilzer (:ddkilzer) 2011-04-25 16:05:04 PDT
Created attachment 90976 [details]
Patch

Reviewed by NOBODY (OOPS!).

To enable HTTP pipelining post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::readBooleanPreference): Re-added.  Originally added in
r76756 and removed in r84120.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
HTTP pipelining if use default is set to true.  Added macro
guards to match those in ResourceRequestMac.mm.
---
 2 files changed, 32 insertions(+), 2 deletions(-)
Comment 1 WebKit Review Bot 2011-04-25 16:07:16 PDT
Attachment 90976 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Pratik Solanki 2011-04-25 16:45:58 PDT
Comment on attachment 90976 [details]
Patch

I can't r+ but the patch looks fine. Though initializeMaximumHTTPConnectionCountPerHost is getting to be quite a misnamed function now.
Comment 3 David Kilzer (:ddkilzer) 2011-04-26 06:39:27 PDT
(In reply to comment #2)
> (From update of attachment 90976 [details])
> I can't r+ but the patch looks fine. Though initializeMaximumHTTPConnectionCountPerHost is getting to be quite a misnamed function now.

Do you have a suggestion for a new name?
Comment 4 David Kilzer (:ddkilzer) 2011-04-26 11:14:01 PDT
Committed r84932: <http://trac.webkit.org/changeset/84932>