WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
59372
Restore user default for enabling HTTP pipelining
https://bugs.webkit.org/show_bug.cgi?id=59372
Summary
Restore user default for enabling HTTP pipelining
David Kilzer (:ddkilzer)
Reported
2011-04-25 16:05:04 PDT
Created
attachment 90976
[details]
Patch Reviewed by NOBODY (OOPS!). To enable HTTP pipelining post-SnowLeopard, use this command: defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::readBooleanPreference): Re-added. Originally added in
r76756
and removed in
r84120
. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable HTTP pipelining if use default is set to true. Added macro guards to match those in ResourceRequestMac.mm. --- 2 files changed, 32 insertions(+), 2 deletions(-)
Attachments
Patch
(2.84 KB, patch)
2011-04-25 16:05 PDT
,
David Kilzer (:ddkilzer)
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2011-04-25 16:07:16 PDT
Attachment 90976
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pratik Solanki
Comment 2
2011-04-25 16:45:58 PDT
Comment on
attachment 90976
[details]
Patch I can't r+ but the patch looks fine. Though initializeMaximumHTTPConnectionCountPerHost is getting to be quite a misnamed function now.
David Kilzer (:ddkilzer)
Comment 3
2011-04-26 06:39:27 PDT
(In reply to
comment #2
)
> (From update of
attachment 90976
[details]
) > I can't r+ but the patch looks fine. Though initializeMaximumHTTPConnectionCountPerHost is getting to be quite a misnamed function now.
Do you have a suggestion for a new name?
David Kilzer (:ddkilzer)
Comment 4
2011-04-26 11:14:01 PDT
Committed
r84932
: <
http://trac.webkit.org/changeset/84932
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug