Bug 59371

Summary: Convert fast/events/focusingUnloadedFrame.html to dumpAsText
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mihai Parparita
Reported 2011-04-25 16:04:22 PDT
Convert fast/events/focusingUnloadedFrame.html to dumpAsText
Attachments
Patch (72.28 KB, patch)
2011-04-25 16:05 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Patch for landing (72.32 KB, patch)
2011-04-25 16:27 PDT, Mihai Parparita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2011-04-25 16:05:08 PDT
Created attachment 90977 [details] Patch
Tony Chang
Comment 2 2011-04-25 16:18:53 PDT
Comment on attachment 90977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90977&action=review > LayoutTests/fast/events/focusingUnloadedFrame.html:22 > + setTimeout(step2, 100); Nit: I wonder if we can lower this timeout to 0.
Mihai Parparita
Comment 3 2011-04-25 16:26:46 PDT
(In reply to comment #2) > Nit: I wonder if we can lower this timeout to 0. Seems to work even without the timeout. Will upload a new patch.
Mihai Parparita
Comment 4 2011-04-25 16:27:47 PDT
Created attachment 91002 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-04-25 19:26:20 PDT
Comment on attachment 91002 [details] Patch for landing Clearing flags on attachment: 91002 Committed r84865: <http://trac.webkit.org/changeset/84865>
WebKit Commit Bot
Comment 6 2011-04-25 19:26:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.